Skip to content

Only delete init .py if in the cwd#5600

Closed
adhami3310 wants to merge 3 commits into
mainfrom
only-delete-__init__.py-if-in-the-cwd
Closed

Only delete init .py if in the cwd#5600
adhami3310 wants to merge 3 commits into
mainfrom
only-delete-__init__.py-if-in-the-cwd

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@adhami3310 adhami3310 closed this Jul 19, 2025
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR makes significant architectural changes to move away from FastAPI to using Starlette directly, which is the underlying web framework that FastAPI is built upon. The changes include:

  1. Moving FastAPI import to dev dependencies and adding Starlette as a main dependency
  2. Cleaning up FastAPI-related code in the core application
  3. Fixing a safety issue with __init__.py file deletion behavior
  4. Reorganizing and updating dependency management in pyproject.toml

This is a well-structured change that simplifies the codebase by removing an unnecessary layer (FastAPI) while maintaining the core functionality through Starlette. The changes are particularly focused on making the framework more efficient and safer.

Confidence score: 4 /5

  1. This PR is generally safe to merge but requires careful testing of HTTP endpoints
  2. The score reflects high confidence in the technical approach while acknowledging the broad scope of FastAPI removal
  3. Key files needing attention:
    • reflex/app.py - Verify ASGI app handling works correctly
    • reflex/utils/exec.py - Test init.py deletion behavior
    • Any files that directly interact with HTTP endpoints

4 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 19, 2025

CodSpeed Performance Report

Merging #5600 will not alter performance

Comparing only-delete-init.py-if-in-the-cwd (4a78108) with main (9114d21)

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant